Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new methods for the /status/filesystems endpoint #88

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Add new methods for the /status/filesystems endpoint #88

merged 3 commits into from
Feb 29, 2024

Conversation

ekouts
Copy link
Collaborator

@ekouts ekouts commented Feb 27, 2024

No description provided.

@ekouts ekouts self-assigned this Feb 27, 2024
@ekouts ekouts requested a review from jpdorsch February 27, 2024 15:25
jpdorsch
jpdorsch reviewed Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@jpdorsch jpdorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also provide the endpoint /status/filesystems/<cluster> do you think it makes sense to also provide such a method passing an argument like cluster or system?

jpdorsch
jpdorsch approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@jpdorsch jpdorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ekouts ekouts merged commit a3752c7 into eth-cscs:main Feb 29, 2024
5 checks passed
@ekouts ekouts deleted the feat/filesystems branch February 29, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpdorsch jpdorsch jpdorsch approved these changes

Assignees

@ekouts ekouts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekouts @jpdorsch