Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release script improvements #1157

Merged
merged 2 commits into from
May 31, 2024

Conversation

msimberg
Copy link
Collaborator

  • Check that user is authenticated before proceeding with release
  • Be explicit about repo (otherwise gh will not make the release if there's no default repo set, as I had the first time I tried this version of the script)

I've tested the first point, but not the second.

@RMeli will you port this over to DLA-Future-Fortran or would you like a PR?

@msimberg msimberg self-assigned this May 31, 2024
@msimberg msimberg requested review from rasolca, RMeli and albestro and removed request for rasolca May 31, 2024 13:24
@RMeli
Copy link
Member

RMeli commented May 31, 2024

PRs always welcome. ;) But I can definitely take care of this port.

Copy link
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rasolca rasolca added this to the v0.5.1 milestone May 31, 2024
@rasolca rasolca merged commit 7eeba0a into eth-cscs:master May 31, 2024
4 checks passed
github-actions bot pushed a commit that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants