Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ncbi update option #589

Merged
merged 3 commits into from
May 1, 2023
Merged

Conversation

JohnBioinf
Copy link
Contributor

I ran into problems using the NCBITaxa class.
Initiating the class always triggers a check if the current data base is not up to date. This causes other processes to throw sqlite errors when they want to access the database at the same time.

Therefore I added an option on initializing the class to not update the database. The default in this pull request still is that an automatic update is triggered, hence this pull request is down stream compatible. If any software relies on the automatic update on class initialization.

I changed the official documentation to clarify the way how the data base can be updated. And further added a few explanation on some option regarding the initialization of the class and a formatting error.

Currently I need some try and except statement to catch the sqlite errors in my own project. This could be avoided with this pull request.

If you find this helpful I would be glad if you merge it.

Thanks
John

@jhcepas jhcepas merged commit 41fe093 into etetoolkit:ete3 May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants