allow any callable as argument to TreeStyle.set_layout_fn #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows any callable object to be set as the layout function of a
TreeStyleobject.Currently, only objects whose type match
types.FunctionTypeortypes.MethodTypeare allowed. This behavior excludes otherwise valid Python callables, e.g. partial functions created withfunctools.partial, or any used-defined class that implements__call__, irrespective of whether the actual call would succeed or not.The PR fixes this by using the
callablebuilt-in function for checking the layout function's type.