Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/eip2200 sload gas again (and ECIP1086 nullified) #36

Merged
merged 2 commits into from
Feb 27, 2020

Conversation

meowsbits
Copy link
Contributor

Rel #35, and would leave the only thing left to do for that issue to possibly implement EIP1884 as a requirement of EIP2200 (which is still debatable).

  • Reverts implementation of EIP2200 setting SLOAD gas=800.
  • Reverts implementation of EIP1086 which "allowed" EIP2200 to continue with SLOAD gas=200.

With this change, Kotti and Mordor testnets will be able to continue as-is (and no other networks supported by default will be broken either).

This reverts commit 9ad9394d1caeaa2631ac9359497734e53615c572.
This ECIP allowed an incorrect specification for EIP2200
which is no longer needed, since the incorrect spec
was actually 'correct'.

Signed-off-by: meows <b5c6@protonmail.com>
Copy link
Contributor

@tzdybal tzdybal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@meowsbits meowsbits merged commit 7cd60ae into master Feb 27, 2020
@meowsbits meowsbits deleted the fix/eip2200-sload-gas-again branch February 27, 2020 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants