vm,vars: install SLOAD constantGas to eip2200 #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whether on not EIP2200 specifies SLOAD constant gas is a matter of interpretation and contention. The document presumes the simultaneity of 1884, but does not do so explicitly. However, EIP2200's engineering DOES NEED the SLOAD constant gas at 800, whether it specifies it or not. Please see #35 as a starting point for reading through some of the history here. For all networks supported, and theoretically all networks properly using 2200, change is a noop; since 2200 MUST be accompanied by 1884. The reason for this change is to make the code the same as ethereum/go-ethereum, eliminating recurring merge conflicts that raise eyebrows. Signed-off-by: meows <b5c6@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whether on not EIP2200 specifies SLOAD constant gas is a matter of interpretation and contention.
The document presumes the simultaneity of 1884, but does not do so explicitly.
However, EIP2200's engineering DOES NEED the SLOAD constant gas at 800, whether it clearly specifies it or not.
Please see #35 as a starting point for reading through some of the history
here.
For all networks supported, and theoretically all networks properly using 2200,
this change is a no-op; since 2200 MUST be accompanied by 1884.
The reason for this change is to make the code the same as ethereum/go-ethereum,
eliminating recurring merge conflicts that raise eyebrows.
Signed-off-by: meows b5c6@protonmail.com