Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update --snapshot-count to reflect new reduced default for 3.6+ and include new tls min/max #650

Merged
merged 3 commits into from
Mar 25, 2023

Conversation

jmhbnz
Copy link
Member

@jmhbnz jmhbnz commented Mar 7, 2023

  1. A quick docs follow-up after Return default snapshot count to 10,000 etcd#15408. For 3.6+ the default --snapshot-count has been reduced to 10,000.

Refer etcd-io/etcd#15360

 

  1. Additionally this pull request includes documentation for tls min/max options which were recently backported to 3.5 and 3.4 so need to be added to the operations guide.

Refer:

Signed-off-by: James Blair <mail@jamesblair.net>
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you @jmhbnz

Signed-off-by: James Blair <mail@jamesblair.net>
@jmhbnz jmhbnz changed the title Update --snapshot-count to reflect new reduced default for 3.6+ Update --snapshot-count to reflect new reduced default for 3.6+ and include new tls min/max Mar 16, 2023
@jmhbnz
Copy link
Member Author

jmhbnz commented Mar 16, 2023

Hey @ahrtr - I've included the 3.5 op guide change here for tls min/max options. Hope that's ok, I can separate it if necessary.

@ahrtr
Copy link
Member

ahrtr commented Mar 16, 2023

Hey @ahrtr - I've included the 3.5 op guide change here for tls min/max options. Hope that's ok, I can separate it if necessary.

It isn't a big deal.

cc @spzala

Signed-off-by: James Blair <mail@jamesblair.net>
@jmhbnz
Copy link
Member Author

jmhbnz commented Mar 16, 2023

Note to maintainers to hold off merging this until etcd-io/etcd#15486 merges.

Edit: This is now ready to merge, @spzala can you please take a look, thanks!

@spzala
Copy link
Member

spzala commented Mar 25, 2023

Note to maintainers to hold off merging this until etcd-io/etcd#15486 merges.

Edit: This is now ready to merge, @spzala can you please take a look, thanks!

@jmhbnz I was out of office but back now..reviewing now. Thanks!

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jmhbnz

@spzala spzala merged commit f1c652f into etcd-io:main Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants