-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update --snapshot-count
to reflect new reduced default for 3.6+ and include new tls min/max
#650
Conversation
Signed-off-by: James Blair <mail@jamesblair.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you @jmhbnz
Signed-off-by: James Blair <mail@jamesblair.net>
--snapshot-count
to reflect new reduced default for 3.6+--snapshot-count
to reflect new reduced default for 3.6+ and include new tls min/max
Hey @ahrtr - I've included the 3.5 op guide change here for tls min/max options. Hope that's ok, I can separate it if necessary. |
Signed-off-by: James Blair <mail@jamesblair.net>
Note to maintainers to hold off merging this until etcd-io/etcd#15486 merges. Edit: This is now ready to merge, @spzala can you please take a look, thanks! |
@jmhbnz I was out of office but back now..reviewing now. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jmhbnz
--snapshot-count
has been reduced to 10,000.Refer etcd-io/etcd#15360
Refer: