Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content/en/docs/next/op-guide/monitoring.md: Add distributed tracing #373

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

lilic
Copy link
Contributor

@lilic lilic commented Jun 10, 2021

Fixes #280. Original PR that added this feature etcd-io/etcd#12919.

@gyuho @nate-double-u @chalin please take a look, thank you!

@lilic lilic force-pushed the add-open-tel-docs branch from 4c1adf0 to 5c184b7 Compare June 10, 2021 11:58
@lilic
Copy link
Contributor Author

lilic commented Jun 10, 2021

@hexfusion
Copy link
Contributor

looks great thank you!

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thx!

Copy link
Contributor

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @lilic!

I've made a couple suggestions in line.

content/en/docs/next/op-guide/monitoring.md Outdated Show resolved Hide resolved
content/en/docs/next/op-guide/monitoring.md Outdated Show resolved Hide resolved
content/en/docs/next/op-guide/monitoring.md Outdated Show resolved Hide resolved
@lilic lilic force-pushed the add-open-tel-docs branch from e37ed86 to c1ec42f Compare June 11, 2021 08:41
@lilic
Copy link
Contributor Author

lilic commented Jun 11, 2021

@nate-double-u thank you so much for your suggestions, I have applied them, please have another look!

Direct preview -> https://deploy-preview-373--etcd.netlify.app/docs/next/op-guide/monitoring/#distributed-tracing

@nate-double-u nate-double-u merged commit a5cf630 into etcd-io:main Jun 11, 2021
@nate-double-u
Copy link
Contributor

Looks good, thanks @lilic!

@lilic lilic deleted the add-open-tel-docs branch June 14, 2021 07:57
@nate-double-u nate-double-u mentioned this pull request Jun 15, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[3.5] Add initial docs for experimental distributed tracing feature
4 participants