Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcdctl/check: create progress bar for datascale #9707

Merged
merged 1 commit into from
May 9, 2018
Merged

etcdctl/check: create progress bar for datascale #9707

merged 1 commit into from
May 9, 2018

Conversation

spzala
Copy link
Member

@spzala spzala commented May 8, 2018 •
edited
Loading

Create a progress bar. The bar will show progress for a given workload.

Fixes #9328

@spzala
etcdctl/check: create progress bar for datascale
8ba41d5 
Create a progress bar. The bar will show progress for a given workload.

Fixes etcd-io#9328
@spzala
Copy link
Member Author

spzala commented May 8, 2018

/cc @gyuho

@spzala spzala requested a review from gyuho May 8, 2018 22:40
@spzala
Copy link
Member Author

spzala commented May 8, 2018

An example output of the progress bar.

# ./bin/etcdctl check datascale
Start data scale check for work load [10000 key-value pairs, 1024 bytes per key-value, 50 concurrent clients].
 10000 / 10000 Boooooooooooooooooooooooooooooooooooooooooooooo! 100.00%2s
PASS: Approximate system memory used : 15.76 MB.

@spzala
Copy link
Member Author

spzala commented May 9, 2018

/retest

gyuho
gyuho approved these changes May 9, 2018
View reviewed changes
Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @spzala!

@gyuho gyuho merged commit e0b74d4 into etcd-io:master May 9, 2018
@spzala
Copy link
Member Author

spzala commented May 12, 2018

@gyuho yrw and thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyuho gyuho gyuho approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spzala @gyuho