Documentation: add grpc gateway watch example #6864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6afbcd0 to
93cfdfd
Compare
grpc-gateway will CloseSend but still want to receive updates.
93cfdfd to
f498842
Compare
f498842 to
6eeed51
Compare
added 2 commits
November 18, 2016 11:37
Shows how to use watch via grpc gateway.
6eeed51 to
ccf154e
Compare
|
Turns out etcd was closing watches when it shouldn't. Fixed. |
|
Confirmed that it works now. LGTM. /cc @xiang90 |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP until grpc-gateway side fixes get in