Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: use glide #5670

Closed
wants to merge 1 commit into from
Closed

vendor: use glide #5670

wants to merge 1 commit into from

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Jun 15, 2016

For #5658.

@gyuho
Copy link
Contributor Author

gyuho commented Jun 15, 2016

/cc @xiang90 @heyitsanthony What do you think?

glide + glide vc seems working well.

# converting Godeps to glide
cd $GOPATH/src/github.com/coreos/etcd/
mv cmd/Godeps .
rm -rf cmd/vendor
mv cmd/ ..

glide init
cat glide.yaml

glide update --strip-vendor --strip-vcs --update-vendored
glide vc --only-code --no-tests

mv ../cmd .
mv glide.* ./cmd
mv vendor/ ./cmd
git status ./cmd


# update gRPC dependency
vim $GOPATH/src/github.com/coreos/etcd/cmd/glide.yaml
# change version to:
# e78224b060cf3215247b7be455f80ea22e469b66

cd $GOPATH/src/github.com/coreos/etcd/
rm -rf Godeps vendor
mv cmd/glide.lock glide.lock
mv cmd/glide.yaml glide.yaml
mv cmd/vendor vendor

glide update --strip-vendor --strip-vcs --update-vendored google.golang.org/grpc
glide vc --only-code --no-tests

mv glide* ./cmd
mv vendor ./cmd
cat cmd/glide.yaml
git status ./cmd


# add a dependency
glide get

@gyuho
Copy link
Contributor Author

gyuho commented Jun 15, 2016

Deletion is large because it removes READMEs and test files. And test will fail because I tested updating gRPC dependency and there was another breaking change. This is a proof of concept.

@heyitsanthony
Copy link
Contributor

does cd cmd/ && glide update work or does glide still have to shuffle directories like godep?

@gyuho
Copy link
Contributor Author

gyuho commented Jun 15, 2016

Yeah it was self-vendoring the etcd... Maybe I was doing wrong.

@gyuho gyuho changed the title [WIP] vendor: experiment glide vendor: use glide Jun 15, 2016
@gyuho
Copy link
Contributor Author

gyuho commented Jun 15, 2016

glide has an issue with symbolic links... Masterminds/glide#253

We can experiment again once it gets fixed.

@gyuho gyuho closed this Jun 15, 2016
@gyuho gyuho deleted the glide branch June 15, 2016 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants