Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.4] Fix release_notes.tpl.txt by adding a space between Docker image name and version #19162

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Jan 10, 2025

Add space between ${ETCD_VER} and Path

Chery-pick commit 519a2e3 / pull request #19153.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Add space between ${ETCD_VER} and Path

Chery-pick commit 519a2e3 / pull
request etcd-io#19153.

Co-authored-by: sunfeilong <31331079+sunfeilong@users.noreply.github.com>
Signed-off-by: Ivan Valdes <ivan@vald.es>
@ivanvc
Copy link
Member Author

ivanvc commented Jan 10, 2025

/retest

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit e34100c into etcd-io:release-3.4 Jan 10, 2025
18 checks passed
@ivanvc ivanvc deleted the release-3.4 branch January 10, 2025 18:26
@ivanvc ivanvc restored the release-3.4 branch January 10, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants