Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.4] Allow updateClusterVersion when downgrading from 3.5. #17821

Merged
merged 1 commit into from
Apr 23, 2024
Merged

[3.4] Allow updateClusterVersion when downgrading from 3.5. #17821

merged 1 commit into from
Apr 23, 2024

Conversation

siyuanfoundation
Copy link
Contributor

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

#17818

Tested with 1 server cluster downgrade

bin/etcd
curl http://127.0.0.1:2379/version
>> {"etcdserver":"3.5.13","etcdcluster":"3.5.0"}

# stop 3.5 server and restart with 3.4 binary
../etcd-3.4/bin/etcd --next-cluster-version-compatible
>> ...
>> mvcc: downgrade meta bucket: remove keys [confState, term]
>> ...
>> etcdserver/membership: updated the cluster version from 3.5 to 3.4

curl http://127.0.0.1:2379/version
>> {"etcdserver":"3.4.31","etcdcluster":"3.4.0"}

@siyuanfoundation siyuanfoundation mentioned this pull request Apr 18, 2024
Closed
4 tasks
@siyuanfoundation
Copy link
Contributor Author

@ahrtr @serathius @seshachalam-yv

seshachalam-yv
seshachalam-yv approved these changes Apr 19, 2024
View reviewed changes
Copy link

@seshachalam-yv seshachalam-yv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you, @siyuanfoundation, for addressing this issue. I've verified the fix locally and everything looks good.

ahrtr
ahrtr reviewed Apr 19, 2024
View reviewed changes
etcdserver/api/membership/cluster_test.go Outdated Show resolved Hide resolved
etcdserver/api/membership/cluster.go Outdated Show resolved Hide resolved
@siyuanfoundation siyuanfoundation mentioned this pull request Apr 22, 2024
Merged
@siyuanfoundation
Allow updateClusterVersion when downgrading from 3.5.
0d62c99 
Signed-off-by: Siyuan Zhang <sizhang@google.com>
@siyuanfoundation siyuanfoundation requested a review from ahrtr April 22, 2024 22:44
@ahrtr ahrtr merged commit 48b0c49 into etcd-io:release-3.4 Apr 23, 2024
17 checks passed
@ahrtr
Copy link
Member

ahrtr commented Apr 23, 2024

Please also update the changelog for 3.4.32. thx

tjungblu added a commit to tjungblu/etcd that referenced this pull request Apr 25, 2024
@tjungblu
add quota to endpoint status response
fcd9bc8 
This adds the configured backend quota bytes to the endpoint status response.
related discussion in etcd-io#17821

Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
@tjungblu tjungblu mentioned this pull request Apr 25, 2024
Merged
tjungblu added a commit to tjungblu/etcd that referenced this pull request Apr 25, 2024
@tjungblu
add quota to endpoint status response
11b4025 
This adds the configured backend quota bytes to the endpoint status response.
related discussion in etcd-io#17821

Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
tjungblu added a commit to tjungblu/etcd that referenced this pull request Apr 25, 2024
@tjungblu
add quota to endpoint status response
bdcff24 
This adds the configured backend quota bytes to the endpoint status response.
related discussion in etcd-io#17821

Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
Scotchman0 pushed a commit to Scotchman0/etcd that referenced this pull request May 7, 2024
@tjungblu @Scotchman0
add quota to endpoint status response
ac3ea82 
This adds the configured backend quota bytes to the endpoint status response.
related discussion in etcd-io#17821

Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
Signed-off-by: Will Russell <will.russell.01@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serathius serathius serathius approved these changes

@seshachalam-yv seshachalam-yv seshachalam-yv approved these changes

@ahrtr ahrtr ahrtr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@siyuanfoundation @ahrtr @serathius @seshachalam-yv