pkg: address golangci var-naming issues #17584
Conversation
| @@ -50,7 +50,7 @@ import ( | |||
| "go.etcd.io/etcd/client/pkg/v3/transport" | |||
| "go.etcd.io/etcd/client/pkg/v3/types" | |||
| clientv3 "go.etcd.io/etcd/client/v3" | |||
| "go.etcd.io/etcd/pkg/v3/grpc_testing" | |||
| grpctesting "go.etcd.io/etcd/pkg/v3/grpc_testing" | |||
There was a problem hiding this comment.
Should we consider changing this at a lower level and rename etcd/pkg/grpc_testing to etcd/pkg/grpctesting?
There was a problem hiding this comment.
Agree to rename etcd/pkg/grpc_testing to etcd/pkg/grpctesting. It's only used by test, so it should be fine to rename it although it's public.
The package was introduced in #12667. I guess the naming just follows the package used by grpc-go: google.golang.org/grpc/test/grpc_testing.
There was a problem hiding this comment.
I'll rename the package. Reference to Go best practice: https://go.dev/blog/package-names, where revive complains about underscores in package names: https://github.com/mgechev/revive/blob/ef34f92/rule/var-naming.go#L66-L72. Unfortunately, revive doesn't provide a website with its rules.
Signed-off-by: Ivan Valdes <ivan@vald.es>
83113be to
d98ff0d
Compare
|
/ok-to-test |
|
@ivanvc Please rebase this PR since we merged lots of PRs recently. cc @serathius |
Addresses the
var-namingissues inpkg.grpc_testingmodule togrpctestingGrpcRecorderstruct toGRPCRecorderPart of #17578
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.