Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add backoff & retries to client config #17307

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Add backoff & retries to client config #17307

merged 1 commit into from
Jan 25, 2024

Conversation

dusk125
Copy link
Contributor

@dusk125 dusk125 commented Jan 23, 2024

Address #17272.

@k8s-ci-robot
Copy link

Hi @dusk125. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tjungblu
Copy link
Contributor

/ok-to-test

@dusk125 dusk125 force-pushed the no-ignore-dialopts branch 2 times, most recently from 2fe7e6f to ce32e9f Compare January 24, 2024 15:09
@tjungblu
Copy link
Contributor

/retest-required

created new flake for #17317

@tjungblu
Copy link
Contributor

/lgtm (non-binding)

we also need to backport to 3.5 and add it to the change logs

ahrtr
ahrtr reviewed Jan 24, 2024
View reviewed changes
client/v3/client_test.go Outdated Show resolved Hide resolved
client/v3/client_test.go Outdated Show resolved Hide resolved
client/v3/client_test.go Outdated Show resolved Hide resolved
@dusk125
add backoff to client config
0857def 
Signed-off-by: Allen Ray <alray@redhat.com>
@dusk125 dusk125 force-pushed the no-ignore-dialopts branch from ce32e9f to 0857def Compare January 24, 2024 16:08
ahrtr
ahrtr approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Thanks

jmhbnz
jmhbnz approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @dusk125

@ahrtr
Copy link
Member

ahrtr commented Jan 25, 2024

cc @fuweid @serathius

@serathius serathius merged commit a818d07 into etcd-io:main Jan 25, 2024
39 checks passed
@dusk125 dusk125 deleted the no-ignore-dialopts branch January 25, 2024 17:11
This was referenced Feb 2, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmhbnz jmhbnz jmhbnz approved these changes

@ahrtr ahrtr ahrtr approved these changes

@serathius serathius serathius approved these changes

Assignees
No one assigned
Labels
ok-to-test
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dusk125 @k8s-ci-robot @tjungblu @ahrtr @serathius @jmhbnz