Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.4] Use the correct log library to print log messages to prevent nil pointer panicking #17270

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Jan 18, 2024

Fix #17265

Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
@ahrtr ahrtr changed the title [3.4] Use the correct log library to print log messages [3.4] Use the correct log library to print log messages to prevent nil pointer panicking Jan 18, 2024
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ahrtr

@ahrtr ahrtr merged commit d441d74 into etcd-io:release-3.4 Jan 18, 2024
12 checks passed
@ahrtr ahrtr deleted the nil_log_20240118 branch June 12, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants