[3.5] Backport adding digest for etcd base image #17205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ensure etcd official image builds can be reproduced. Signed-off-by: James Blair <mail@jamesblair.net>
fuweid
approved these changes
Jan 8, 2024
serathius
approved these changes
Jan 8, 2024
ahrtr
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request proposes backporting #17122 to
release-3.5.Currently etcd official release image builds are not reproducible as we currently use the mutable
latesttag for our distroless base image. With this backport they would become reproducible through a switch to immutable digests.It needs to be called out there is a tradeoff that before each release we would ideally consider updating to the latest upstream image sha to ensure our reproducible builds are using the most current base image. For
mainwe have dependabot keeping on top of this. For release branches I don't believe dependabot can be configured to analyse non default branch so we would need to do it manually.Relates to #16987.