Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test ApplyConfState after restart #17021

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Test ApplyConfState after restart #17021

merged 1 commit into from
Nov 27, 2023

Conversation

serathius
Copy link
Member

@serathius serathius commented Nov 26, 2023 •
edited
Loading

This test was written to show issue with #17019.
We cannot disable validation on entries before v3 state because we are still using them to update confState, which is still loaded from snapshot and not v3.

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@serathius serathius force-pushed the test-applyconfstate branch 2 times, most recently from 30e8316 to d306ed5 Compare November 26, 2023 13:58
@serathius serathius marked this pull request as ready for review November 26, 2023 14:02
@serathius serathius mentioned this pull request Nov 26, 2023
Draft
@serathius
Copy link
Member Author

/retest

@serathius
Test ApplyConfState after restart
e192a05 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
@serathius
Copy link
Member Author

cc @ahrtr @fuweid @chaochn47 @siyuanfoundation

fuweid
fuweid approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serathius serathius merged commit 62b772c into etcd-io:main Nov 27, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr ahrtr approved these changes

@fuweid fuweid fuweid approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serathius @k8s-ci-robot @fuweid @ahrtr