-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add initialization for epMu in contetx client #17018
Conversation
fixes etcd-io#17001 Signed-off-by: Mofi Rahman <mofi@google.com>
Hi @moficodes. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks for fixing this @moficodes
Edit: We should consider backporting this fix to release-3.5
once merged.
I think this pr is fine and backporting this fix to release-3.5 once merged asap, thanks. |
Why hasn't this PR been included in the latest 3.5.x version? @jmhbnz |
It looks like the backport is still to be completed, contributions are welcomed. I've re-opened the issue that was closed automatically when this pr was merged so the backport can be completed. |
@jmhbnz I can give this backport a try! |
Tested against the demo code provided in PR etcd-io#17001 References: - etcd-io#17001 - etcd-io#17018
Tested against the demo code provided in PR etcd-io#17001 References: - etcd-io#17001 - etcd-io#17018 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
References: - etcd-io#17001 - etcd-io#17018 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
fixes #17001