Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add initialization for epMu in contetx client #17018

Merged
merged 1 commit into from
Nov 25, 2023

Conversation

moficodes
Copy link
Member

fixes #17001

fixes etcd-io#17001

Signed-off-by: Mofi Rahman <mofi@google.com>
@k8s-ci-robot
Copy link

Hi @moficodes. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmhbnz
Copy link
Member

jmhbnz commented Nov 24, 2023

/ok-to-test

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for fixing this @moficodes

Edit: We should consider backporting this fix to release-3.5 once merged.

@113xiaoji
Copy link

I think this pr is fine and backporting this fix to release-3.5 once merged asap, thanks.

@serathius serathius merged commit ce0a737 into etcd-io:main Nov 25, 2023
37 checks passed
@moficodes moficodes deleted the patch-01 branch November 27, 2023 14:43
@113xiaoji
Copy link

Why hasn't this PR been included in the latest 3.5.x version? @jmhbnz

@jmhbnz
Copy link
Member

jmhbnz commented Apr 2, 2024

Why hasn't this PR been included in the latest 3.5.x version? @jmhbnz

It looks like the backport is still to be completed, contributions are welcomed.

I've re-opened the issue that was closed automatically when this pr was merged so the backport can be completed.

@henrybear327
Copy link
Contributor

Why hasn't this PR been included in the latest 3.5.x version? @jmhbnz

It looks like the backport is still to be completed, contributions are welcomed.

I've re-opened the issue that was closed automatically when this pr was merged so the backport can be completed.

@jmhbnz I can give this backport a try!

henrybear327 added a commit to henrybear327/etcd that referenced this pull request Apr 3, 2024
henrybear327 added a commit to henrybear327/etcd that referenced this pull request Apr 3, 2024
Tested against the demo code provided in PR etcd-io#17001

References:
- etcd-io#17001
- etcd-io#17018

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
henrybear327 added a commit to henrybear327/etcd that referenced this pull request Apr 4, 2024
References:
- etcd-io#17001
- etcd-io#17018

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants