Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor v2 deprecation tests to allow different cluster config #16991

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Refactor v2 deprecation tests to allow different cluster config #16991

merged 1 commit into from
Nov 22, 2023

Conversation

serathius
Copy link
Member

Split from #16989

@serathius
Refactor v2 deprecation tests to allow different cluster config
cac2882 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
@serathius serathius force-pushed the refactor-v2-deprecation-tests branch from 4da78fb to cac2882 Compare November 22, 2023 13:36
@serathius
Copy link
Member Author

cc @ahrtr

chaochn47
chaochn47 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@chaochn47 chaochn47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this would be needed to reject unexpected v2 requests stored in WAL.

@serathius
Copy link
Member Author

ping @ahrtr

ahrtr
ahrtr approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@serathius serathius merged commit 9d97cc2 into etcd-io:main Nov 22, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaochn47 chaochn47 chaochn47 approved these changes

@ahrtr ahrtr ahrtr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@serathius @ahrtr @chaochn47