Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.4] Backport clientv3 naming implementation #16800

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

chaochn47
Copy link
Member

Part of #16740

Backport #12614, #12667, #12669 and #12675 to release-3.4

Corresponding tests should have been enabled.

Please DO NOT MERGE until this PR is rebased on top of #16795

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@chaochn47 chaochn47 requested a review from fuweid October 20, 2023 04:37
@chaochn47 chaochn47 force-pushed the release-3.4-clientv3-naming-impl branch from d8be61d to 65e6915 Compare October 20, 2023 04:53
@chaochn47 chaochn47 changed the title Release 3.4 clientv3 naming impl [3.4] Backport clientv3 naming implementation Oct 20, 2023
@chaochn47 chaochn47 force-pushed the release-3.4-clientv3-naming-impl branch from 65e6915 to 23f6937 Compare October 20, 2023 05:08
@ahrtr ahrtr mentioned this pull request Oct 20, 2023
24 tasks
@ahrtr
Copy link
Member

ahrtr commented Oct 24, 2023

#16795 has been merged, please rebase this PR, thx

Signed-off-by: Chao Chen <chaochn@amazon.com>
@chaochn47 chaochn47 force-pushed the release-3.4-clientv3-naming-impl branch from 23f6937 to d2cc99a Compare October 24, 2023 15:10
@chaochn47 chaochn47 marked this pull request as ready for review October 24, 2023 15:10
@chaochn47
Copy link
Member Author

Thanks @ahrtr! I have rebased the PR. PTAL~

Signed-off-by: Chao Chen <chaochn@amazon.com>
@chaochn47 chaochn47 force-pushed the release-3.4-clientv3-naming-impl branch from d2cc99a to fa2e868 Compare October 24, 2023 15:59
@chaochn47
Copy link
Member Author

chaochn47 commented Oct 24, 2023

Known flaky test should be fixed by #15708 as long as it is backported. Retrying...

=== RUN   TestMemberPromoteMemberNotLearner
{"level":"warn","ts":"2023-10-24T16:05:20.153924Z","caller":"clientv3/retry_interceptor.go:62","msg":"retrying of unary invoker failed","target":"endpoint://client-506ab2c9-cfe6-49c3-ad6a-a51f4cd85750/localhost:56549785845390747520","attempt":0,"error":"rpc error: code = FailedPrecondition desc = etcdserver: can only promote a learner member"}
{"level":"warn","ts":"2023-10-24T16:05:20.159936Z","caller":"clientv3/retry_interceptor.go:62","msg":"retrying of unary invoker failed","target":"endpoint://client-506ab2c9-cfe6-49c3-ad6a-a51f4cd85750/localhost:56549785845390747520","attempt":0,"error":"rpc error: code = FailedPrecondition desc = etcdserver: can only promote a learner member"}
{"level":"warn","ts":"2023-10-24T16:05:25.361631Z","caller":"clientv3/retry_interceptor.go:62","msg":"retrying of unary invoker failed","target":"endpoint://client-506ab2c9-cfe6-49c3-ad6a-a51f4cd85750/localhost:56549785845390747520","attempt":0,"error":"rpc error: code = Unavailable desc = etcdserver: request timed out"}
    cluster_test.go:326: expect error to contain can only promote a learner member, got etcdserver: request timed out
--- FAIL: TestMemberPromoteMemberNotLearner (5.35s)

https://github.com/etcd-io/etcd/actions/runs/6629437579/job/18008727923?pr=16800

Signed-off-by: Chao Chen <chaochn@amazon.com>
@chaochn47 chaochn47 force-pushed the release-3.4-clientv3-naming-impl branch from fa2e868 to e61f1d8 Compare October 24, 2023 16:17
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thx

@ahrtr
Copy link
Member

ahrtr commented Oct 24, 2023

@ahrtr ahrtr merged commit e031012 into etcd-io:release-3.4 Oct 25, 2023
12 checks passed
@chaochn47 chaochn47 deleted the release-3.4-clientv3-naming-impl branch October 25, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants