-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.4] Backport clientv3 naming implementation #16800
Merged
ahrtr
merged 3 commits into
etcd-io:release-3.4
from
chaochn47:release-3.4-clientv3-naming-impl
Oct 25, 2023
Merged
[3.4] Backport clientv3 naming implementation #16800
ahrtr
merged 3 commits into
etcd-io:release-3.4
from
chaochn47:release-3.4-clientv3-naming-impl
Oct 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaochn47
force-pushed
the
release-3.4-clientv3-naming-impl
branch
from
October 20, 2023 04:53
d8be61d
to
65e6915
Compare
chaochn47
changed the title
Release 3.4 clientv3 naming impl
[3.4] Backport clientv3 naming implementation
Oct 20, 2023
chaochn47
force-pushed
the
release-3.4-clientv3-naming-impl
branch
from
October 20, 2023 05:08
65e6915
to
23f6937
Compare
#16795 has been merged, please rebase this PR, thx |
Signed-off-by: Chao Chen <chaochn@amazon.com>
chaochn47
force-pushed
the
release-3.4-clientv3-naming-impl
branch
from
October 24, 2023 15:10
23f6937
to
d2cc99a
Compare
Thanks @ahrtr! I have rebased the PR. PTAL~ |
Signed-off-by: Chao Chen <chaochn@amazon.com>
chaochn47
force-pushed
the
release-3.4-clientv3-naming-impl
branch
from
October 24, 2023 15:59
d2cc99a
to
fa2e868
Compare
Known flaky test should be fixed by #15708 as long as it is backported. Retrying...
https://github.com/etcd-io/etcd/actions/runs/6629437579/job/18008727923?pr=16800 |
Signed-off-by: Chao Chen <chaochn@amazon.com>
chaochn47
force-pushed
the
release-3.4-clientv3-naming-impl
branch
from
October 24, 2023 16:17
fa2e868
to
e61f1d8
Compare
ahrtr
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thx
serathius
approved these changes
Oct 25, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #16740
Backport #12614, #12667, #12669 and #12675 to release-3.4
Corresponding tests should have been enabled.
Please DO NOT MERGE until this PR is rebased on top of #16795
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.