[3.5] api: fix duplicate gateway url issue #16490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run `scripts/genproto.sh --skip-protodoc` and checkout
server/wal/walpb/record.pb.go because we still use go.etcd.io/etcd/raft/v3
instead of go.etcd.io/raft/v3.
Before
```
➜ etcd git:(release-3.5) etcdctl put foo bar
OK
➜ etcd git:(release-3.5) etcdctl get -w json foo
{"header":{"cluster_id":14841639068965178418,"member_id":10276657743932975437,"revision":2,"raft_term":2},"kvs":[{"key":"Zm9v","create_revision":2,"mod_revision":2,"version":1,"value":"YmFy"}],"count":1}
➜ etcd git:(release-3.5) etcdctl compact 2
compacted revision 2
➜ etcd git:(release-3.5) http_proxy= curl -L http://127.0.0.1:2379/v3/maintenance/hashkv -X POST -d '{"revsion":2}'
Not Found
```
After
```bash
➜ etcd git:(bp-16464) http_proxy= curl -L http://127.0.0.1:2379/v3/maintenance/hashkv -X POST -d '{"revsion":2}'
{"header":{"cluster_id":"14841639068965178418","member_id":"10276657743932975437","revision":"2","raft_term":"3"},"hash":3305255506,"compact_revision":"2"}%
```
Signed-off-by: Wei Fu <fuweid89@gmail.com>
|
Could you also add at least the cases for hash and hashkv from #16489? |
Added. I also increase the timeout for grpcproxy testcase. No idea why it took so long. |
ahrtr
reviewed
Aug 28, 2023
Signed-off-by: Benjamin Wang <wachao@vmware.com> Signed-off-by: Wei Fu <fuweid89@gmail.com>
Signed-off-by: Wei Fu <fuweid89@gmail.com>
ahrtr
approved these changes
Aug 28, 2023
|
Please also add a changelog item for 3.5. thx |
Sure. Will file pr after merged. |
jmhbnz
approved these changes
Aug 29, 2023
fuweid
added a commit
to fuweid/etcd
that referenced
this pull request
Aug 29, 2023
Signed-off-by: Wei Fu <fuweid89@gmail.com>
|
Thanks @ahrtr @jmhbnz for review. The changelog is here https://github.com/etcd-io/etcd/pull/16503/files ping @serathius the change looks good to you? |
fuweid
added a commit
to fuweid/etcd
that referenced
this pull request
Aug 29, 2023
Signed-off-by: Wei Fu <fuweid89@gmail.com>
serathius
approved these changes
Aug 30, 2023
ahrtr
added a commit
that referenced
this pull request
Aug 30, 2023
CHANGELOG: add #16490 item in CHANGELOG-3.5.md
iiamabby
pushed a commit
to iiamabby/etcd
that referenced
this pull request
Nov 30, 2023
Signed-off-by: Wei Fu <fuweid89@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run
scripts/genproto.sh --skip-protodocand checkout server/wal/walpb/record.pb.go because we still use go.etcd.io/etcd/raft/v3 instead of go.etcd.io/raft/v3.Before
After
Backport #16464
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.