-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.5] Backport expose socket options #16435
[3.5] Backport expose socket options #16435
Conversation
so that they cabn be configured via config file. Co-authored-by: Shawn Gerrard <shawn.gerrard@gmail.com> Signed-off-by: James Blair <mail@jamesblair.net>
As another follow-up we should update our sample etcd config file to make it clear how these options should be specified. |
18ba7aa
to
66faec3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
66faec3
to
f23416e
Compare
Co-authored-by: Shawn Gerrard <shawn.gerrard@gmail.com> Signed-off-by: James Blair <mail@jamesblair.net>
f23416e
to
164175d
Compare
Could you also add a changelog item for 3.5? @jmhbnz |
Note: the option |
Hmm if the feature is not in |
I guess "no need" here means "there is no need" :) New 3.4 release won't consider backporting this PR. |
I do not get why my previous comment caused confusion:)
|
Whoops completely misread lol, thanks @chaochn47 🤦🏻♂️ |
Currently in
main
it's possible to specify--socket-reuse-port
and--socket-reuse-address
in the config file. However, the same cannot be done forrelease-3.5
.An added complication is that the format for specifying these in the config file differs slightly from the command line parameter. Example below:
This backport addresses the immediate bug of configuration via file for these options not being possible in
release-3.5
.In future, we should also consider aligning the way the option name should be used in both the configuration file and the command flags.
Relates to #16399.