-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Templated arm64 integration and e2e workflows for main and release-3.5 #16152
Conversation
8e20091
to
1dafc61
Compare
1dafc61
to
2195968
Compare
Signed-off-by: James Blair <mail@jamesblair.net>
Signed-off-by: James Blair <mail@jamesblair.net>
2195968
to
856790d
Compare
Note for reviewers: Workflows have been tested |
tldr; we need to update the release process to incorporate those workflow failures as a signal. I think we are stomping into new ground. Periodic workflows themselves are not enough to guarantee that next etcd release will work on ARM. They will run, fail but not result in any action if they fail. We need to make them somehow actionable. To paint the picture. Example of what I mean is process that K8s has. First a dashboard that gives clear view of all periodic tests for all supported versions. Dashboard for v1.24 testing I own https://k8s-testgrid.appspot.com/sig-instrumentation-tests#kind-json-logging-1.24 I think to make the periodic workflows failures be a signal for release we need to adapt to a process similar to this. Of course we will not try to rollout TestGrid ourselves, but as etcd joins Kubernetes it would be nice to have some integration. We already have a release process and release owners defined, we just need to make results from those periodics a clear signal for our releases. |
Completely agree. Additionally I am intending to scale up our runners in future to have multiple on each box (we have tons of compute idle on each box) so that we can actually run some of these workflows on each pr also. Edit: The scaling of runners to enable arm64 signal on pr is tracked under: #15951 |
Hey @serathius, @ahrtr - Can you please take another look at this? I'm keen to see how these tests will behave against 3.5. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @jmhbnz
I think we can discuss the adapting the similar K8s process in a separate session. Leave to @serathius to approve and merge this PR.
Follow-on from #16151 to setup scheduled workflows for
arm64
nightly integration and e2e suites against therelease-3.5
branch.Arm64 integration and e2e suites now adopt a shared re-usable workflow template which is slightly customised for
main
orrelease-3.5
.Fixes #15832