-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documenting etcd infrastructure and establish basic controls #15998
Conversation
Hey @dims - Keen for your thoughts on this proposal given your work earlier this year getting initial servers created. |
@jmhbnz +100 from me on all points. A simple |
fc6f66f
to
856cfc1
Compare
Thanks for the feedback @dims, I have updated to a simple markdown table list to get us started, and proposed a starting list of two most active maintainers along with @chaochn47 and I who both have been helping with the infra recently, and then yourself as a CNCF representative. @ahrtr, @serathius - Can you please let me know if we should be adding anyone else to the list for now? I don't mind maintaining it in future as we iterate. |
856cfc1
to
032160d
Compare
|
||
Access to the infrastructure is defined by the infra admins table below: | ||
|
||
| Name | Github | K8s Slack | Email | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make it a separate file in some format that could be used for automation? There is no benefit of displaying this here to readers of this doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My initial suggestion was to use a new github team called infra-admins
. That would unblock the work that @hh and I wanted to do together for an actions workflow that will run a snippet of terraform for automatically creating infra.
We can also then use github api's for other automation. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no strong opinion here. Ideally, moving the list to a separate file and automating the process (e.g. grant access or revoke access) is good, but we will most likely not update the list very often. So putting the list here is simple and good enough for now, and we can update it in future when needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think initially let's get these basic controls merged so I can start implementation, I'm keen to continue contributing in this area and iterating on this in future.
This commit introduces initial processes for managing access and support options. Signed-off-by: James Blair <mail@jamesblair.net>
032160d
to
3d40ee6
Compare
Overall looks good to me. Thanks @jmhbnz . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thanks again @jmhbnz .
Leave it to @serathius to approve and merge.
This pull request gets some initial documentation in place collating information that used to spread across a variety of github issues.
Additionally this pull request proposes some very basic improvements to how we control access to the infrastructure. Below is a summary of the proposal:
root
access just by connecting to a server, with no second factor of authentication required.root
usage behindsudo
with a password so users need to have a second factor (key + sudo password) forroot
.We need to do this because we can't enforce that users set a password for their ssh key meaning if a threat actor gets hold of a users key they could have free reign on etcd infrastructure.
In future we are likely to improve this further by shifting towards more as code management of etcd infrastructure, however I believe it is important we at least get some basic processes in place while we work on long term improvements.
Fixes: #15952