tests/robustness: Expect revisions to be unique for Kubernetes Traffic #15909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmhbnz
reviewed
May 16, 2023
| @@ -73,6 +73,10 @@ type etcdTraffic struct { | |||
| largePutSize int | |||
| } | |||
|
|
|||
| func (t etcdTraffic) ExpectUniqueRevision() bool { | |||
There was a problem hiding this comment.
I'm curious about the reasons for putting these bools into functions versus just having it as part of traffic config? Are we expecting to have complex criteria in future for determining if a given traffic type will expect unique revisions? It feels like something that is more static to me but I might be missing something.
There was a problem hiding this comment.
Because it's property of traffic code, it could be inferred from write types used, however it's also not clear for them. For example there are three etcd requests types currently that generate multiple operation per revision.
chaochn47
reviewed
May 17, 2023
ahrtr
reviewed
May 17, 2023
1fc2868 to
40146fa
Compare
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
40146fa to
4872b67
Compare
ahrtr
approved these changes
May 23, 2023
jmhbnz
approved these changes
May 23, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @ahrtr @ptabor @jmhbnz @chaochn47