-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.4] Separate grpc server #15620
Merged
serathius
merged 7 commits into
etcd-io:release-3.4
from
serathius:separate-grpc-server-3.4
Apr 4, 2023
Merged
[3.4] Separate grpc server #15620
serathius
merged 7 commits into
etcd-io:release-3.4
from
serathius:separate-grpc-server-3.4
Apr 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
…er separate from http server Difference in load configuration for watch delay tests show how huge the impact is. Even with random write scheduler grpc under http server can only handle 500 KB with 2 seconds delay. On the other hand, separate grpc server easily hits 10, 100 or even 1000 MB within 100 miliseconds. Priority write scheduler that was used in most previous releases is far worse than random one. Tests configured to only 5 MB to avoid flakes and taking too long to fill etcd. Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
serathius
force-pushed
the
separate-grpc-server-3.4
branch
from
April 3, 2023 14:11
e0c67cd
to
47d4ff2
Compare
ahrtr
approved these changes
Apr 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fuweid
approved these changes
Apr 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM(non-binding)
ivanvc
added a commit
to ivanvc/etcd
that referenced
this pull request
Feb 19, 2024
Finish backporting the remaining functions from the original backport from PR etcd-io#15620. Backported commit 65add8c Signed-off-by: Ivan Valdes <ivan@vald.es>
ivanvc
added a commit
to ivanvc/etcd
that referenced
this pull request
Feb 19, 2024
Finish backporting the remaining functions from the original backport from PR etcd-io#15620. Backported commit 65add8c Signed-off-by: Ivan Valdes <ivan@vald.es>
ivanvc
added a commit
to ivanvc/etcd
that referenced
this pull request
Feb 19, 2024
Finish backporting the remaining functions from the original backport from PR etcd-io#15620. Backport of commit 65add8c Signed-off-by: Ivan Valdes <ivan@vald.es>
ivanvc
added a commit
to ivanvc/etcd
that referenced
this pull request
Feb 20, 2024
Finish backporting the remaining functions from the original backport from PR etcd-io#15620. Backport of commit 65add8c. Co-authored-by: Marek Siarkowicz <siarkowicz@google.com> Signed-off-by: Ivan Valdes <ivan@vald.es>
ivanvc
added a commit
to ivanvc/etcd
that referenced
this pull request
Feb 20, 2024
Finish backporting the remaining functions from the original backport from PR etcd-io#15620. Backport of commit 65add8c. Co-authored-by: Marek Siarkowicz <siarkowicz@google.com> Signed-off-by: Ivan Valdes <ivan@vald.es>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #15446 and #15588
cc @ahrtr @ptabor