Remove e2e from coverage calculation #15544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Blair <mail@jamesblair.net>
|
Please find and cleanup files with |
Ok so taking this one step at a time to get my head around it, here is our list of grep -Ri "//go:build" | grep cov
pkg/osutil/signal_linux.go://go:build linux && !cov
pkg/osutil/signal.go://go:build !linux || cov
tests/framework/e2e/etcd_spawn_nocov.go://go:build !cov
tests/framework/e2e/etcd_spawn_cov.go://go:build cov
tests/e2e/zap_logging_test.go://go:build !cov
tests/e2e/ctl_v3_completion_test.go://go:build !cov
tests/e2e/v3_cipher_suite_test.go://go:build !cov && !cluster_proxy
tests/e2e/ctl_v3_watch_no_cov_test.go://go:build !cov
tests/e2e/ctl_v3_watch_cov_test.go://go:build cov@serathius are we simply removing the |
|
Depends on the case. We could either:
|
Signed-off-by: James Blair <mail@jamesblair.net>
Signed-off-by: James Blair <mail@jamesblair.net>
Signed-off-by: James Blair <mail@jamesblair.net>
|
Hey @serathius - Many thanks for the guidance above. I've had a go a the remaining cleanup you described. Hoping I have understood this correctly. Please take a look when you can and let me know what you think 🙏🏻 |
Signed-off-by: James Blair <mail@jamesblair.net>
serathius
reviewed
Mar 30, 2023
serathius
approved these changes
Mar 30, 2023
Signed-off-by: James Blair <mail@jamesblair.net>
|
Looks great! This is exactly what we want. |
4 tasks
fuweid
added a commit
to fuweid/etcd
that referenced
this pull request
Oct 17, 2023
The etcd-io#15544 has removed the `build_cov` build. And after go1.20, we use `-cover` buildflag to enable coverage exporter. We don't need to maintain main_test.go anymore. ```bash ➜ pwd /home/fuwei/go/src/go.etcd.io/etcd/etcdctl ➜ go build -o /tmp/etcdctl -cover ./ ➜ mkdir /tmp/etcdctl-covdata ➜ GOCOVERDIR=/tmp/etcdctl-covdata /tmp/etcdctl get /health ➜ go tool covdata percent -i=/tmp/etcdctl-covdata go.etcd.io/etcd/etcdctl/v3 coverage: 66.7% of statements go.etcd.io/etcd/etcdctl/v3/ctlv3 coverage: 83.3% of statements go.etcd.io/etcd/etcdctl/v3/ctlv3/command coverage: 15.4% of statements ``` REF: https://go.dev/testing/coverage/ Signed-off-by: Wei Fu <fuweid89@gmail.com>
fuweid
added a commit
to fuweid/etcd
that referenced
this pull request
Oct 17, 2023
The etcd-io#15544 has removed the `build_cov` build. And after go1.20, we use `-cover` buildflag to enable coverage exporter. We don't need to maintain main_test.go anymore. ```bash ➜ pwd /home/fuwei/go/src/go.etcd.io/etcd/etcdctl ➜ go build -o /tmp/etcdctl -cover ./ ➜ mkdir /tmp/etcdctl-covdata ➜ GOCOVERDIR=/tmp/etcdctl-covdata /tmp/etcdctl get /health ➜ go tool covdata percent -i=/tmp/etcdctl-covdata go.etcd.io/etcd/etcdctl/v3 coverage: 66.7% of statements go.etcd.io/etcd/etcdctl/v3/ctlv3 coverage: 83.3% of statements go.etcd.io/etcd/etcdctl/v3/ctlv3/command coverage: 15.4% of statements ``` REF: https://go.dev/testing/coverage/ Signed-off-by: Wei Fu <fuweid89@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes e2e from the coverage collected in
scripts/test.sh.Ref #15522