scripts: Add testing of etcd in local image in release workflow. #15505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have added version checks and carried forward the review comments from before. Apologies for the git mess-up. |
ahrtr
reviewed
Mar 18, 2023
ahrtr
reviewed
Mar 20, 2023
ahrtr
reviewed
Mar 23, 2023
ahrtr
approved these changes
Mar 23, 2023
There was a problem hiding this comment.
LGTM with a minor comment.
cc @ptabor @serathius @spzala to take a look.
serathius
reviewed
Mar 23, 2023
serathius
reviewed
Mar 23, 2023
serathius
reviewed
Mar 23, 2023
serathius
reviewed
Mar 23, 2023
|
Running detached container with server and running etcdctl put&get seems like overkill for bash. |
|
@serathius @ahrtr Thank you for your feedback. I have incoporated them and have updated the PR. Please review. |
ahrtr
reviewed
Mar 24, 2023
Signed-off-by: Prasad Chandrasekaran <prasadc@vmware.com>
ahrtr
reviewed
Mar 24, 2023
ahrtr
reviewed
Mar 24, 2023
Signed-off-by: Prasad Chandrasekaran <prasadc@vmware.com>
ahrtr
approved these changes
Mar 24, 2023
serathius
reviewed
Mar 24, 2023
Signed-off-by: Prasad Chandrasekaran <prasadc@vmware.com>
Signed-off-by: Prasad Chandrasekaran <prasadc@vmware.com>
serathius
approved these changes
Mar 24, 2023
This was referenced Mar 30, 2023
|
@pchan could you backport this PR to both 3.5 and 3.4? thx |
This was referenced Apr 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the previous PR #15350 for details.
Fixes: #15139
@ahrtr @chaochn47