Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.4] mvcc: push down RangeOptions.limit argv into index tree to reduce memory overhead #15137

Merged
merged 3 commits into from
Jan 19, 2023
Merged

[3.4] mvcc: push down RangeOptions.limit argv into index tree to reduce memory overhead #15137

merged 3 commits into from
Jan 19, 2023

Conversation

fuweid
Copy link
Member

@fuweid fuweid commented Jan 18, 2023

tangcong and others added 3 commits January 18, 2023 10:01
@tangcong @fuweid
mvcc: push down RangeOptions.limit argv into index tree
d48f7ad 
(cherry picked from commit 26c930f)
Signed-off-by: Wei Fu <fuweid89@gmail.com>
@serathius @fuweid
etcdserver: Fix invalid count returned on Range with Limit
1246c52 
(cherry picked from commit 182aef6)
Signed-off-by: Wei Fu <fuweid89@gmail.com>
@fuweid
mvcc: update ut for Revisions/CountRevisions
931cf9a 
It is kind of backport from etcd-io#14124.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
@ahrtr
Copy link
Member

ahrtr commented Jan 18, 2023

This PR changed the protocol between etcdserver and client side, it may have some impact on all clients, e.g., K8s. So I tend not to backport this one.

@fuweid
Copy link
Member Author

fuweid commented Jan 18, 2023

Hi @ahrtr , would you please to point out the protocol change in the pr? I didn't follow you. Thanks!

@ahrtr
Copy link
Member

ahrtr commented Jan 18, 2023

Hi @ahrtr , would you please to point out the protocol change in the pr? I didn't follow you. Thanks!

Previously I was thinking the RangeResult.Count value might change with this PR, but it seems that it doesn't. So I think this PR is acceptable.

ahrtr
ahrtr approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you!

@fuweid
Copy link
Member Author

fuweid commented Jan 18, 2023

Thanks!

@ahrtr
Copy link
Member

ahrtr commented Jan 18, 2023

Please also add a changelog item.

@fuweid
Copy link
Member Author

fuweid commented Jan 19, 2023

Please also add a changelog item.

Sure!

It might be late because of holiday.
I will send the pr next Tuesday~

@ahrtr ahrtr merged commit e4b1542 into etcd-io:release-3.4 Jan 19, 2023
@fuweid fuweid deleted the backport-11990-to-3.4 branch January 24, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr ahrtr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fuweid @ahrtr @tangcong @serathius