server/auth: fix panic when a malformed jwt with missing required cl… #15002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ims is encountered Signed-off-by: Lanre Adelowo <yo@lanre.wtf>
|
Thank you. Could you add a couple of unit test cases? |
|
@adelowo any update? |
|
Hi @ahrtr apologies. Just got back from the holidays. I’d resolve this over the next day |
|
@adelowo any update on this PR? |
|
Since there is no response from the original author, please anyone feel free to resurrect this PR (e.g. fork a new branch on top this one, and then add unit test). |
|
Hello @ahrtr, I can take it up |
|
Thanks @ArkaSaha30 . Please
|
|
Sure @ahrtr , I will create a fresh PR with this as the first commit. |
|
New PR ref:#15639 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14931