Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changelog: add item to cover the fix for double barrier running into stack overflow #14659

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Oct 31, 2022

Signed-off-by: Benjamin Wang wachao@vmware.com

cc @mitake @ptabor @spzala @serathius

…stack overflow error

Signed-off-by: Benjamin Wang <wachao@vmware.com>
@codecov-commenter
Copy link

Codecov Report

Merging #14659 (378da24) into main (a1018db) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #14659      +/-   ##
==========================================
- Coverage   75.63%   75.57%   -0.07%     
==========================================
  Files         457      457              
  Lines       37292    37292              
==========================================
- Hits        28207    28184      -23     
- Misses       7324     7334      +10     
- Partials     1761     1774      +13     
Flag Coverage Δ
all 75.57% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/pkg/v3/tlsutil/tlsutil.go 83.33% <0.00%> (-8.34%) ⬇️
client/v3/leasing/util.go 91.66% <0.00%> (-6.67%) ⬇️
raft/rafttest/node.go 95.00% <0.00%> (-5.00%) ⬇️
server/proxy/grpcproxy/watch.go 91.90% <0.00%> (-4.63%) ⬇️
client/v3/concurrency/session.go 88.63% <0.00%> (-4.55%) ⬇️
server/storage/mvcc/kvstore_compaction.go 95.65% <0.00%> (-4.35%) ⬇️
server/etcdserver/api/v3rpc/member.go 93.54% <0.00%> (-3.23%) ⬇️
client/v3/experimental/recipes/key.go 75.34% <0.00%> (-2.74%) ⬇️
client/v3/experimental/recipes/double_barrier.go 68.83% <0.00%> (-2.60%) ⬇️
client/v3/concurrency/election.go 79.68% <0.00%> (-2.35%) ⬇️
... and 16 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ahrtr
Copy link
Member Author

ahrtr commented Nov 2, 2022

@spzala @serathius @mitake @ptabor PTAL, thx

@ahrtr
Copy link
Member Author

ahrtr commented Nov 7, 2022

ping @mitake @spzala @serathius

@mitake
Copy link
Contributor

mitake commented Nov 7, 2022

LGTM, thanks @ahrtr

@mitake mitake merged commit 0dd8846 into etcd-io:main Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants