Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport PR 14322 to release-3.5 #14547

Merged
merged 2 commits into from
Oct 3, 2022
Merged

Backport PR 14322 to release-3.5 #14547

merged 2 commits into from
Oct 3, 2022

Conversation

mitake
Copy link
Contributor

@mitake mitake commented Oct 3, 2022

mitake added 2 commits October 3, 2022 23:00
@mitake
*: handle auth invalid token and old revision errors in watch
7b568f2 
Signed-off-by: Hitoshi Mitake <h.mitake@gmail.com>
@mitake
tests: a test case for watch with auth token expiration
528dd82 
Signed-off-by: Hitoshi Mitake <h.mitake@gmail.com>
@mitake mitake changed the title 3.5 backport 14322 Backport PR 14322 to release-3.5 Oct 3, 2022
spzala
spzala approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mitake thank you! lgtm. Rerunning failed test which seems not related to changes. I think this should be backported to 3.4 as well?

ahrtr
ahrtr approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank yo @mitake

Please consider to backport this to 3.4 as well if needed.

@ahrtr ahrtr merged commit 5daf35b into etcd-io:release-3.5 Oct 3, 2022
@ahrtr
Copy link
Member

ahrtr commented Oct 3, 2022

Please update both 3.5 and 3.4 changelog after finishing the 3.4 backport, thx

@mitake mitake deleted the 3.5-backport-14322 branch October 4, 2022 13:45
@mitake
Copy link
Contributor Author

mitake commented Oct 4, 2022

Thanks @spzala @ahrtr ! Yeah I'll open PRs for backporting to 3.4 and updating the changelog.

@mitake mitake mentioned this pull request Oct 4, 2022
Merged
@serathius serathius mentioned this pull request Nov 14, 2022
Closed
22 tasks
@ahrtr ahrtr mentioned this pull request Dec 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr ahrtr approved these changes

@spzala spzala spzala approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mitake @ahrtr @spzala