-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release-3.5: server/etcdmain: add configurable cipher list to gRPC proxy listener #14500
Conversation
Please fix the fmt & test error. Usually we only backport bug fix to stable release, but exposing secure ciphers is a common and important part of any service, so It's OK to backport it. |
Please also remove the CHANGELOG item from 3.6 and add a new item for changelog-3.5. FYI. #14476 (comment) |
3ab7ee3
to
935625c
Compare
|
Sounds good, thanks! |
Signed-off-by: Allen Ray <alray@redhat.com>
935625c
to
db55011
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Re-running failed tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a backport of #14308