-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clientv3: fix init client error #14368
Conversation
Two comments:
|
I have modified and added unit tests. |
@happlins you need to combine four commits into one |
sorry,I have revised it. |
The minimum version supported should be Please also consider to enhance the unit test to cover more scenarios,such as,
|
any update on this? |
I'm sorry. I've been too busy recently. I've modified the minimum version and added unit test |
ab68bfe
to
d3eea7c
Compare
Signed-off-by: happlins <happlins@foxmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you @happlins
Since there is no response from other maintainers and it's a safe change to me, so let me merge this PR. |
Signed-off-by: caojiamingalan <alan.c.19971111@gmail.com>
fix clientv3 init client error
close #14323
Signed-off-by: happlins happlins@foxmail.com
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.