[3.4] Support linearizable renew lease for 3.4 #14177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, the only diff seams to be
everything else is the same |
|
the test TestV3CurlAuthClientTLSCertAuth also failed here recently. Another flake? |
Yes, let me take care of this one. |
bd9e9dd to
c84ef43
Compare
|
cc @serathius @spzala @ptabor PTL, thx. |
|
I decided not to cherry pick this PR. We should only backport security fix and major/critical bug fixes. |
Cherry pick etcd-io#13932 to 3.4. When etcdserver receives a LeaseRenew request, it may be still in progress of processing the LeaseGrantRequest on exact the same leaseID. Accordingly it may return a TTL=0 to client due to the leaseID not found error. So the leader should wait for the appliedID to be available before processing client requests. Signed-off-by: Benjamin Wang <wachao@vmware.com>
c84ef43 to
07d2b1d
Compare
|
Moved this PR from 3.4.19 to 3.4.20. Part of #14232 |
|
@serathius @ptabor @spzala PTAL, thx. |
serathius
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick 13932 to 3.4.
Part of 14105
When etcdserver receives a LeaseRenew request, it may be still in
progress of processing the LeaseGrantRequest on exact the same
leaseID. Accordingly it may return a TTL=0 to client due to the
leaseID not found error. So the leader should wait for the appliedID
to be available before processing client requests.
Signed-off-by: Benjamin Wang wachao@vmware.com
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.