*: use T.TempDir to create temporary test directory
#13644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The directory created by `T.TempDir()` and is automatically removed when the test and all its subtests complete. Reference: https://pkg.go.dev/testing#T.TempDir Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
|
cc @ptabor |
ahrtr
approved these changes
Jan 26, 2022
ptabor
reviewed
Jan 27, 2022
| t.Fatal(err) | ||
| } | ||
| tmpdirs[i] = d | ||
| tmpdirs[i] = t.TempDir() |
There was a problem hiding this comment.
In such situation where we have meaningful identifier in the directory name that points on the instance of etcd from the test I would prefer to preserve it in the path.
rootTmpDir=t.TempDir()
for i := range peers {
d, err := os.MkdirTemp(rootTmpDir, fmt.Sprintf("%d-%d.etcd", i, e2e.EtcdProcessBasePort+i))
}
This makes it easier to correlate logs (and path in the logs) with a directory that might contain a corrupted state.
ptabor
approved these changes
Jan 27, 2022
spzala
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can write less code by using the
T.TempDirfunction from thetestingpackage to create temporary test directory. The directory created byT.TempDiris automatically removed when the test and all its subtests complete.Reference: https://pkg.go.dev/testing#T.TempDir