etcdserver: Fix 64 KB websocket notification message limit #12402
Conversation
|
Some tests fail but it's unrelated to this PR, they fail in release-3.4 anyway :) |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions. |
|
Can you merge the PR? |
|
@xiang90 PING |
This fixes etcd being unable to send any message longer than 64 KB as a notification over the websocket. This was because the older version of grpc-websocket-proxy was used and WithMaxRespBodyBufferSize option wasn't set.
| @@ -286,6 +286,7 @@ func (sctx *serveCtx) createMux(gwmux *gw.ServeMux, handler http.Handler) *http. | |||
| return outgoing | |||
| }, | |||
| ), | |||
| wsproxy.WithMaxRespBodyBufferSize(0x7fffffff), | |||
There was a problem hiding this comment.
I'm scarried by unlimited buffers.
Should this one by in the same order of magnitude as:
Line 180 in 2c8de24
?
There was a problem hiding this comment.
I think messages that are generated by the server itself shouldn't be limited by the websocket library. Because it's very funny if the server generates the message but is then unable to actually send it. If it wants to limit message size it should split the message itself, and that's in fact what it actually does sometimes. So I think this buffer shouldn't be limited...
There was a problem hiding this comment.
The PR to the master branch is already merged long ago #12403
There was a problem hiding this comment.
Thank you. It was not clear from the RP description that its a backport.
Hi!
I discovered a bug in etcd which makes it impossible for clients to receive server messages (notifications) longer than 64 KB via the websocket.
It's easy to reproduce, you just need to create a key/value entry in etcd with a value longer than 64 KB and you won't get it back in the notification.
A test example is here:
https://gist.github.com/vitalif/a634ac0543e6cacdda4ec288d922d9cf
The patch fixes this issue by updating grpc-websocket-proxy and setting the WithMaxRespBodyBufferSize option to 2^31-1.