-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
picker: replace picker with V2Picker ,picker is deprecated #12384
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12384 +/- ##
==========================================
- Coverage 63.28% 63.20% -0.08%
==========================================
Files 448 448
Lines 62342 62348 +6
==========================================
- Hits 39451 39410 -41
- Misses 18325 18372 +47
Partials 4566 4566
Continue to review full report at Codecov.
|
/retest |
Thank you for the contribution. Could you, please elaborate/link more in commit & PR description on the purpose of the change. Looking at the current state of https://godoc.org/google.golang.org/grpc/balancer#Picker, in the current version its called "Picker" again (but conforms to your interface). Is there a plan to rename it back after update of the grpc library ? |
done |
I see the title changed. But what about lack of V2 picker in the current state of library: https://godoc.org/google.golang.org/grpc/balancer#Picker |
Please read https://github.com/etcd-io/etcd/blob/master/CONTRIBUTING.md#contribution-flow.