Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

picker: replace picker with V2Picker ,picker is deprecated #12384

Closed
wants to merge 1 commit into from
Closed

picker: replace picker with V2Picker ,picker is deprecated #12384

wants to merge 1 commit into from

Conversation

Murphylu1993
Copy link
Contributor

@codecov-io
Copy link

codecov-io commented Oct 10, 2020

Codecov Report

Merging #12384 into master will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12384      +/-   ##
==========================================
- Coverage   63.28%   63.20%   -0.08%     
==========================================
  Files         448      448              
  Lines       62342    62348       +6     
==========================================
- Hits        39451    39410      -41     
- Misses      18325    18372      +47     
  Partials     4566     4566              
Impacted Files Coverage Δ
clientv3/balancer/picker/picker.go 50.00% <ø> (ø)
clientv3/balancer/balancer.go 86.66% <100.00%> (+0.30%) ⬆️
clientv3/balancer/picker/err.go 100.00% <100.00%> (ø)
clientv3/balancer/picker/roundrobin_balanced.go 100.00% <100.00%> (ø)
pkg/netutil/netutil.go 61.47% <0.00%> (-7.38%) ⬇️
pkg/fileutil/purge.go 69.56% <0.00%> (-6.53%) ⬇️
api/etcdserverpb/raft_internal_stringer.go 32.25% <0.00%> (-6.46%) ⬇️
clientv3/namespace/watch.go 87.87% <0.00%> (-6.07%) ⬇️
etcdctl/ctlv3/command/lease_command.go 65.34% <0.00%> (-5.95%) ⬇️
etcdserver/api/v3rpc/interceptor.go 69.18% <0.00%> (-3.49%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00e49d0...696613c. Read the comment docs.

@Murphylu1993 Murphylu1993 changed the title picker: replace picker with V2Picker picker: replace picker with V2Picker Oct 10, 2020
@Murphylu1993 Murphylu1993 changed the title picker: replace picker with V2Picker picker: replace picker with V2Picker Oct 10, 2020
@Murphylu1993 Murphylu1993 changed the title picker: replace picker with V2Picker picker: replace picker with V2Picker Oct 10, 2020
@Murphylu1993
Copy link
Contributor Author

/retest

@ptabor
Copy link
Contributor

ptabor commented Oct 10, 2020

Thank you for the contribution. Could you, please elaborate/link more in commit & PR description on the purpose of the change.

Looking at the current state of https://godoc.org/google.golang.org/grpc/balancer#Picker, in the current version its called "Picker" again (but conforms to your interface). Is there a plan to rename it back after update of the grpc library ?

@Murphylu1993 Murphylu1993 changed the title picker: replace picker with V2Picker picker: replace picker with V2Picker Oct 10, 2020
@Murphylu1993 Murphylu1993 changed the title picker: replace picker with V2Picker picker: replace picker with V2Picker Oct 10, 2020
@Murphylu1993 Murphylu1993 changed the title picker: replace picker with V2Picker picker: replace picker with V2Picker ,picker is deprecated Oct 10, 2020
@Murphylu1993
Copy link
Contributor Author

Thank you for the contribution. Could you, please elaborate/link more in commit & PR description on the purpose of the change.

Looking at the current state of https://godoc.org/google.golang.org/grpc/balancer#Picker, in the current version its called "Picker" again (but conforms to your interface). Is there a plan to rename it back after update of the grpc library ?

done

@ptabor
Copy link
Contributor

ptabor commented Oct 10, 2020

Thank you for the contribution. Could you, please elaborate/link more in commit & PR description on the purpose of the change.
Looking at the current state of https://godoc.org/google.golang.org/grpc/balancer#Picker, in the current version its called "Picker" again (but conforms to your interface). Is there a plan to rename it back after update of the grpc library ?

done

I see the title changed. But what about lack of V2 picker in the current state of library: https://godoc.org/google.golang.org/grpc/balancer#Picker

@ptabor
Copy link
Contributor

ptabor commented Oct 15, 2020

This PR overlaps with broader: #12398 2859e9f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants