Allow commandline overrides 3.4 #12269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 748ab8c. This is an unnecessary breaking change from upgrading from 3.3, also having both environmental variables and being able to override them via commandline is a highly desired feature.
It should not be a warning: the user explicitly requested an override.
3612ee2 to
cb907dc
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #12268 from master
Addressing issue #12222 see #12222 (comment)
It is a valid workflow to to have defaults in your environmental variables, and then override them on-demand with commandline parameters. The existing change unnecessarily breaks existing clusters when upgrading to 3.4+. I will also do a PR for release-3.4 cherry-pick.