Persist failpoints across member restart #11913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm, thanks for the fix! |
|
LGTM. Thanks! |
jingyih
reviewed
May 19, 2020
| zap.String("failpoint-http-addr", srv.Member.FailpointHTTPAddr), | ||
| zap.String("failpoint-addr", u.Host), | ||
| ) | ||
| srv.etcdCmd = exec.Command(etcdPath, etcdFlags...) | ||
| srv.etcdCmd.Env = []string{"GOFAIL_HTTP=" + u.Host} | ||
| if failpoints != "" { | ||
| srv.etcdCmd.Env = append(srv.etcdCmd.Env, "GOFAIL_FAILPOINTS=" + failpoints) |
There was a problem hiding this comment.
NIT: gofmt is complaining this line
- srv.etcdCmd.Env = append(srv.etcdCmd.Env, "GOFAIL_FAILPOINTS=" + failpoints)
+ srv.etcdCmd.Env = append(srv.etcdCmd.Env, "GOFAIL_FAILPOINTS="+failpoints)
|
Manually fixed fmt. |
|
Thanks @gyuho! I forgot about this one somehow in everything else going on. Appreciate you getting it merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11898
Noticed that if etcd is restarted, we lose track of any gofail failpoints. This PR persists them across restarts.