-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mvcc: add "etcd_mvcc_put_size_in_bytes" metrics #11374
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11374 +/- ##
==========================================
+ Coverage 64.34% 64.64% +0.29%
==========================================
Files 403 403
Lines 37969 37973 +4
==========================================
+ Hits 24432 24548 +116
+ Misses 11887 11779 -108
+ Partials 1650 1646 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Added few nits.
LGTM Might as well add for range and delete? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah this is great! Thanks so much!
/lgtm
…4-upstream-release-3.3 Automated cherry pick of #11374 on release 3.3
…4-upstream-release-3.4 Automated cherry pick of #11374 on release 3.4
CHANGELOG: update from PR #11374
related #11365
@logicalhan @jingyih Please have a look.