Skip to content

Commit

Permalink
Documentation/upgrades: highlight "grpc.ErrClientConnClosing"
Browse files Browse the repository at this point in the history
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
  • Loading branch information
gyuho committed Aug 5, 2019
1 parent ae78761 commit b3cd4f2
Showing 1 changed file with 23 additions and 0 deletions.
23 changes: 23 additions & 0 deletions Documentation/upgrades/upgrade_3_4.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,29 @@ OK
+etcd --peer-trusted-ca-file ca-peer.crt
```

#### Deprecated `grpc.ErrClientConnClosing` error

[`grpc.ErrClientConnClosing`](https://github.com/etcd-io/etcd/issues/9304) has been deprecated.

```diff
import (
+ "go.etcd.io/etcd/clientv3"

"google.golang.org/grpc"
+ "google.golang.org/grpc/codes"
+ "google.golang.org/grpc/status"
)

_, err := kvc.Get(ctx, "a")
-if err == grpc.ErrClientConnClosing {
+if clientv3.IsConnCanceled(err) {

// or
+s, ok := status.FromError(err)
+if ok {
+ if s.Code() == codes.Canceled
```

#### Deprecating `etcd_debugging_mvcc_db_total_size_in_bytes` Prometheus metrics

v3.4 promotes `etcd_debugging_mvcc_db_total_size_in_bytes` Prometheus metrics to `etcd_mvcc_db_total_size_in_bytes`, in order to encourage etcd storage monitoring.
Expand Down

0 comments on commit b3cd4f2

Please sign in to comment.