Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub runners to use ubuntu-latest since they have nested virt #811

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Update GitHub runners to use ubuntu-latest since they have nested virt #811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
153c154
update github runners to use ubuntu-latest since they are 4c and have…
jeefy Aug 5, 2024
418ac4e
change runners that I missed
jeefy Aug 5, 2024
254cd84
fix another missed ubuntu-latest-* instance
jeefy Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/benchmark-template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ on:
runs-on:
required: false
type: string
default: "['ubuntu-latest-8-cores']"
default: "['ubuntu-latest']"
permissions: read-all

jobs:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/robustness_nightly.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
with:
count: 100
testTimeout: 200m
runs-on: "['ubuntu-latest-8-cores']"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REF: #612

The original motivation is not for nested virt. The free-tier runner has limitation. It seems that there was runner agent monitoring memory or cpu usage. If the resource usage is higher than expected, the agent will kill the process actions/runner-images#6680 (comment)

By default, the free-tier runner only has 3 cores. I'm not sure that it can do nested virt.

Copy link

@mrbobbytables mrbobbytables Aug 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The free tier has been upgraded 👍 They are 4 core with 16gb of ram now.

EDIT: They now support nested virtualization as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the information 👍

https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories

runs-on: "['ubuntu-latest']"
arm64:
# GHA has a maximum amount of 6h execution time, we try to get done within 3h
uses: ./.github/workflows/robustness_template.yaml
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/robustness_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
with:
count: 10
testTimeout: 30m
runs-on: "['ubuntu-latest-8-cores']"
runs-on: "['ubuntu-latest']"
arm64:
uses: ./.github/workflows/robustness_template.yaml
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/tests_amd64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@ jobs:
test-linux-amd64-race:
uses: ./.github/workflows/tests-template.yml
with:
runs-on: ubuntu-latest-8-cores
runs-on: ubuntu-latest
targets: "['linux-unit-test-4-cpu-race']"

coverage:
needs:
- test-linux-amd64
- test-linux-amd64-race
runs-on: ubuntu-latest-8-cores
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- id: goversion
Expand Down