#373 Follow-up #375
Merged
#373 Follow-up #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wei Fu <fuweid89@gmail.com>
* Remove duplicate targets in Makefile * Use GOGC=30 to prevent high resource usage Signed-off-by: Wei Fu <fuweid89@gmail.com>
ahrtr
reviewed
Jan 5, 2023
| # with GOMEMLIMIT=2048MiB if the go-version is updated to >=1.19.x. | ||
| # | ||
| # REF: https://github.com/actions/runner-images/issues/6680#issuecomment-1335778010 | ||
| GOGC=30 CPU=4 ENABLE_RACE=true make test |
There was a problem hiding this comment.
It will run race mode for freelist-array as well? I recall that you mentioned running race mode for freelist-array will fail with high possibility? can you clarify this?
There was a problem hiding this comment.
It will run race mode for freelist-array as well?
Yes. make test will run cases for both hashmap and freelist.
I recall that you mentioned running race mode for freelist-array will fail with high possibility?
Yes. It happened yesterday (I run the CI in my forked repo action https://github.com/fuweid/bbolt/actions).
But in this morning, it failed random.... ( So I try to use GOGC env to limit the usage and run it 7 times successfully.
Hopefully it is not flaky in the future.
ptabor
approved these changes
Jan 5, 2023
ahrtr
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up: #373