Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add workaround to tarball without root #1236

Merged
merged 2 commits into from
Dec 5, 2020

Conversation

EduardoRFS
Copy link
Contributor

@EduardoRFS EduardoRFS commented Dec 2, 2020

This is the same behavior as tar --strip-components IIRC. Also it's needed to build @opam/hacl-star-raw. This also enables Tezos to be build using esy

@ManasJayanth
Copy link
Member

Shouldnt one of the roots be followed atleast?

      | [h, ...tail]=>
        let%lwt () = Logs_lwt.info(m => m("warning: multiple root dirs found. "));
        find(h, n - 1)

@EduardoRFS
Copy link
Contributor Author

Nope, multiple roots, means that there is multiple files in the root, most of the time that implies that the tarball doesn't have a wrapping folder, as you can see on

https://github.com/project-everest/hacl-star/releases/download/ocaml-v0.3.0/hacl-star.0.3.0.tar.gz

@ManasJayanth ManasJayanth merged commit 197ff32 into esy:master Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants