Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog sidebar rework #717

Merged
merged 12 commits into from
Mar 3, 2025
Merged

Conversation

Brenosalv
Copy link
Collaborator

#654

Changes on the sidebar from the blog post and comparison pages:

  • Remove "Share this article" section;
  • Remove image from the sidebar;
  • Update text sidebar CTA button;
  • Make TOC items collapsible;
  • Adjust the TOC height according to changes above;
  • Remove unnecessary margins from TOC.

Tests / Screenshots

TOC on the blog post page:
image

TOC on the comparison page:
image

@Brenosalv Brenosalv added the generate-pr-preview Used to kick off a preview build for a PR label Feb 28, 2025
@Brenosalv Brenosalv self-assigned this Feb 28, 2025
@Brenosalv Brenosalv linked an issue Feb 28, 2025 that may be closed by this pull request
@Brenosalv Brenosalv added the enhancement New feature or request label Feb 28, 2025
Copy link

Visit the preview URL for this PR (updated for commit dad2e79):

https://estuary-marketing--pr717-brenosalv-feature-65-u52r10hl.web.app

(expires Sat, 15 Mar 2025 05:40:46 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 76f6b095a0752e5d9c6c890267f9fdc3e392161e

Comment on lines +38 to +40
<OutboundLinkFilled href={dashboardRegisterUrl}>
Start Building For Free
</OutboundLinkFilled>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other link like this opens in a new tab. I would think this would as well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in PR #688

Copy link
Member

@travjenkins travjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@travjenkins travjenkins merged commit ce38fc0 into master Mar 3, 2025
1 check failed
@travjenkins travjenkins deleted the Brenosalv/feature/654-blog-sidebar-rework branch March 3, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request generate-pr-preview Used to kick off a preview build for a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blog sidebar rework
2 participants