Filter connectors better and make connector search page safer
#699
Conversation
Need to exclude and filter out Kelkoo
making stuff a bit more safe updating typing to match what could happen
| {!logo?.childImageSharp?.gatsbyImageData ? ( | ||
| <div | ||
| className={clsx( | ||
| connectorPostCardImage, | ||
| 'icon-wrapper' | ||
| )} | ||
| /> | ||
| ) : ( |
There was a problem hiding this comment.
This logo was 100% missing while running a quick search. So making this safer. Eventually we might want to add a placeholder or something while this is loading.
| {showType ? ( | ||
| <> | ||
| {recommended ? <div style={{ flexBasis: 4 }} /> : null} | ||
| }: ReturnType<typeof normalizeConnector> & { showType?: boolean }) => { |
There was a problem hiding this comment.
This didn't change much but looks like it did because I added a explicit return.
| showType={showAllConnectors} | ||
| /> | ||
| ) | ||
| (connector) => { |
There was a problem hiding this comment.
another explicit return
There was a problem hiding this comment.
We now check this in normalizeConnector.
src/templates/connection.tsx
Outdated
There was a problem hiding this comment.
This should never happen - but being safe
src/utils.ts
Outdated
There was a problem hiding this comment.
We need to add all the filter into the normalizer so that things like search results do not get fed wrong connectors
connectors better and make connector search page safer
setting maximum parallel requests to stop hammering strapi
|
Visit the preview URL for this PR (updated for commit b228685): https://estuary-marketing--pr699-travjenkins-bug-fix-6h6w2zsd.web.app (expires Tue, 11 Mar 2025 15:48:14 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 76f6b095a0752e5d9c6c890267f9fdc3e392161e |
Changes
kelkooTests / Screenshots
Kelkoo cannot be found
Prod
Local