Feat navbar improves

[flavioriper]

Description

We need this to change the navbar to a new version with cards and columns

Mobile version still the same

[github-actions]

Visit the preview URL for this PR (updated for commit a73d81e):

https://estuary-marketing--pr183-feat-navbar-improves-h3fjr09u.web.app

_{(expires Sat, 17 Feb 2024 11:17:46 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 76f6b095a0752e5d9c6c890267f9fdc3e392161e}

[jshearer]

I haven't seen the mocks for this, but overall it looks good! A few nitpicks:

This bottom text looks quite small

Feels like these shouldn't be indented?

This image is pretty blurry

[jeffatestuary]

new build incoming to fix any applicable updates @jshearer

[jshearer]

This is looking good from a presentation standpoint -- it looks way better than the navbar that I hacked together in the beginning!

That being said, there are a few places where this introduces hard-coding of "content" concerns that should really be handled in Strapi. If we're chomping at the bit to get this out then I say let's merge and fast-follow with the updates to de-hardcode these, otherwise really they should be fixed before merging.

[jshearer]

This should pull from Strapi like the current comparison links in the navbar do

[jshearer]

These should also pull from Strapi so when we publish more case studies they automatically show up

[jshearer]

Looks like this isn't used anywhere?

[jshearer]

Love that this is an SVG, but I would also love for us to not be hardcoding "content" like this. Does it make sense to add a field to the case studies model in Strapi for this? What would that field be called? I'm happy to go add it if we come up with a good framing here

[jeffatestuary]

I'm partial to a fast follow on this as agreed it should come from strapi

…

On Thu, Jan 18, 2024 at 10:46 AM Joseph Shearer ***@***.***> wrote: ***@***.**** commented on this pull request. This is looking good from a presentation standpoint -- it looks way better than the navbar that I hacked together in the beginning! That being said, there are a few places where this introduces hard-coding of "content" concerns that should really be handled in Strapi. If we're chomping at the bit to get this out then I say let's merge and fast-follow with the updates to de-hardcode these, otherwise really they should be fixed before merging. ------------------------------ In src/components/HeaderNavbar/Product/items.tsx <#183 (comment)> : > @@ -0,0 +1,30 @@ +import React from "react" +import { StaticImage } from "gatsby-plugin-image" + +export const products = [ + { + name: "Estuary Flow", + to: "/product", + description: "Build fully managed real-time data pipelines in minutes.", + Image: () => <StaticImage src="../../../images/header-book.png" width={20} height={20} alt="book" /> + }, +] + +export const compare = [ This should pull from Strapi like the current comparison links in the navbar do ------------------------------ In src/components/HeaderNavbar/Resources/items.tsx <#183 (comment)> : > + }, +] + +export const tour = [ + { + name: "Product Tour [2 min]", + to: "/why", + }, + { + name: "Real-time 101 [30 min]", + to: "https://try.estuary.dev/webinar-estuary101-ondemand", + }, +] + +export const caseStudies = [ + { These should also pull from Strapi so when we publish more case studies they automatically show up ------------------------------ On src/images/CONNECT&GO.png <#183 (comment)> : Looks like this isn't used anywhere? ------------------------------ On src/svgs/navbar-image-1.svg <#183 (comment)> : Love that this is an SVG, but I would also love for us to not be hardcoding "content" like this. Does it make sense to add a field to the case studies model in Strapi for this? — Reply to this email directly, view it on GitHub <#183 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A5HTFGW2WKJQVXBPNTBNPCDYPE7UPAVCNFSM6AAAAABBYK4TRWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMRZHAZDENRZGU> . You are receiving this because you commented.Message ID: ***@***.***>

[jshearer]

Let's merge with #183 (review) as a fast-follow