Updated to Github workflow (#686)

* Making preview a manual step Shortening how long it lives for * Cutting duration in half * Getting workflow to run again when label changes * Removing Lighthouse
estuary · Feb 13, 2025 · 33faabf · 33faabf
1 parent 65b30c4
commit 33faabf
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 40 deletions.
diff --git a/.github/workflows/deploy-preview.yml b/.github/workflows/deploy-preview.yml
@@ -2,29 +2,16 @@ name: Deploy to Firebase Preview
 
 on:
     pull_request:
-        # We should look into not always running a preview for every PR
-        # paths:
-        #     - .env
-        #     - .firebaserc
-        #     - .lighthouserc.js
-        #     - config.ts
-        #     - gatsby*
-        #     - package.json
-        #     - tsconfig.json
-        #     - types.d.tsconfig
-        #     - yarn.lock
-        #     - content/**
-        #     - patches/**
-        #     - plugins/**
-        #     - src/**
-        #     - static/**
+    label:
+        types: [created, deleted, edited]
 
 concurrency:
     group: preview-${{ github.ref }}
 
 jobs:
     build_and_preview:
         runs-on: ubuntu-2404-large
+        if: contains(github.event.pull_request.labels.*.name, 'generate-pr-preview')
         steps:
             - name: Checkout
               uses: actions/checkout@v3
@@ -65,20 +52,11 @@ jobs:
                   GATSBY_DB_HOST: ${{ secrets.GATSBY_DB_HOST }}
                   GATSBY_DB_PORT: ${{ secrets.GATSBY_DB_PORT }}
                   GATSBY_DB_NAME: ${{ secrets.GATSBY_DB_NAME }}
-            - name: run Lighthouse CI
-              run: |
-                  npm install -g @lhci/cli@0.13.x
-                  lhci autorun
-              env:
-                  LHCI_GITHUB_APP_TOKEN: ${{ secrets.LHCI_GITHUB_APP_TOKEN }}
-                  LHCI_TOKEN: ${{ secrets.LHCI_TOKEN }}
-                  LHCI_BASIC_AUTH_USERNAME: ${{ secrets.LHCI_BASIC_AUTH_USERNAME }}
-                  LHCI_BASIC_AUTH_PASSWORD: ${{ secrets.LHCI_BASIC_AUTH_PASSWORD }}
             - uses: FirebaseExtended/action-hosting-deploy@v0
               id: firebase
               with:
                   repoToken: '${{ secrets.GITHUB_TOKEN }}'
                   firebaseServiceAccount: '${{ secrets.FIREBASE_SERVICE_ACCOUNT }}'
-                  expires: 30d
+                  expires: 15d
                   projectId: estuary-marketing
             - run: echo ${{steps.firebase.outputs.urls}}
diff --git a/.github/workflows/deploy-prod.yml b/.github/workflows/deploy-prod.yml
@@ -53,20 +53,6 @@ jobs:
                   GATSBY_DB_HOST: ${{ secrets.GATSBY_DB_HOST }}
                   GATSBY_DB_PORT: ${{ secrets.GATSBY_DB_PORT }}
                   GATSBY_DB_NAME: ${{ secrets.GATSBY_DB_NAME }}
-            - name: run Lighthouse CI
-              run: |
-                  # Need to set these manually LHCI doesn't support multiple builds
-                  export LHCI_BUILD_CONTEXT__COMMIT_MESSAGE=$(git log --format=%s -n 1 HEAD)
-                  export LHCI_BUILD_CONTEXT__AUTHOR=$(git log --format="$aN <%aE>" -n 1 HEAD)
-                  export LHCI_BUILD_CONTEXT__COMMIT_TIME=$(git log -n1 --pretty="%cI" HEAD)
-                  npm install -g @lhci/cli@0.13.x
-                  lhci autorun
-              env:
-                  LHCI_BUILD_CONTEXT__CURRENT_HASH: ${{ github.sha }}-${{ github.run_id }}
-                  LHCI_GITHUB_APP_TOKEN: ${{ secrets.LHCI_GITHUB_APP_TOKEN }}
-                  LHCI_TOKEN: ${{ secrets.LHCI_TOKEN }}
-                  LHCI_BASIC_AUTH_USERNAME: ${{ secrets.LHCI_BASIC_AUTH_USERNAME }}
-                  LHCI_BASIC_AUTH_PASSWORD: ${{ secrets.LHCI_BASIC_AUTH_PASSWORD }}
             - uses: FirebaseExtended/action-hosting-deploy@v0
               with:
                   repoToken: '${{ secrets.GITHUB_TOKEN }}'